Add Friendly Name to the Entity Picker + FuzzySeq Algo#7291
Merged
Conversation
zsarnett
changed the title
Contributor
Author
|
Waiting on a better fuzzy matching from Donka |
bramkragten
reviewed
Oct 12, 2020
9 tasks
zsarnett
changed the title
zsarnett
force-pushed
the
add-friendly-name-to-picker
branch
from
d439568 to
1548755
Compare
zsarnett
changed the title
zsarnett
force-pushed
the
add-friendly-name-to-picker
branch
from
38d855b to
1548755
Compare
bramkragten
reviewed
Oct 14, 2020
| } | ||
|
|
||
| private _filterChanged(ev): void { | ||
| const filterString = ev.detail.value.toLowerCase(); |
Member
There was a problem hiding this comment.
Should fuzzySequentialMatch take care of the lower case?
Contributor
There was a problem hiding this comment.
I've gone back and forth on that. I eventually landed that it made more sense for the client to decide whether or not casing should matter.
But that being said, I can't really think of any situations in Home Assistant where you'd want to use case-sensitive filtering.
I'd be fine with moving it into the matcher.
Member
There was a problem hiding this comment.
I think it would make sense to move it to the matcher. We could add a flag eventually to match case if needed... But it would make for less duplicate code and simpler implementation.
bramkragten
approved these changes
Oct 14, 2020
… add-friendly-name-to-picker
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: